Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Improve: panda_moveit: Add parameters for perception tutorial #181

Draft
wants to merge 11 commits into
base: ros2
Choose a base branch
from

Conversation

130s
Copy link
Contributor

@130s 130s commented Jun 9, 2023

Issue

Approach toward solution

  • The tutorial is made in the way moveit starts from moveit_config package, which is maintained in this repo. So add them here.
  • Adding a new xacro file that is only found in franka_description.

Related work

@130s 130s marked this pull request as draft June 9, 2023 18:43
@130s 130s force-pushed the feature-panda-moveit-perception branch from 5badec1 to f949062 Compare June 9, 2023 20:43
@130s
Copy link
Contributor Author

130s commented Jun 9, 2023

(Dev-testing) Reading params from a file seems to be failing.
[move_group-5] [ERROR] [1686343188.448424614] [rcl]: Failed to parse global arguments
[move_group-5] terminate called after throwing an instance of 'rclcpp::exceptions::RCLInvalidROSArgsError'
[move_group-5]   what():  failed to initialize rcl: Couldn't parse params file: '--params-file /tmp/launch_params_b7467iww'. Error: Sequences can only be values and not keys in params. Error at line 2
[move_group-5] , at ./src/parse.c:841, at ./src/rcl/arguments.c:406                 
[move_group-5] Stack trace (most recent call last):                                 
[move_group-5] #14   Object "", at 0xffffffffffffffff, in                           
[rviz2-2] QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'

UPDATE: Param file format was wrong, had to be ros2-ified.

@130s 130s force-pushed the feature-panda-moveit-perception branch from f949062 to 8a082a9 Compare June 9, 2023 21:19
@130s 130s force-pushed the feature-panda-moveit-perception branch from 8a082a9 to 646722b Compare June 10, 2023 11:06
<xacro:arg name="use_fake_hardware" default="false"/>
<xacro:arg name="fake_sensor_commands" default="false"/>

<xacro:include filename="$(find franka_description)/robots/panda_arm.xacro"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This single file is obviously not enough as some lines depend on franka_description pkg.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did they switch moveit_tutorials from panda_moveit_config to moveit_resources_panda_moveit_config in ROS2?
I suggest adapting panda_moveit_config for ROS2 (it already has a rolling-devel branch) instead of switching to and bloating moveit_resources.

@130s
Copy link
Contributor Author

130s commented Jun 13, 2023

Did they switch moveit_tutorials from panda_moveit_config to moveit_resources_panda_moveit_config in ROS2?

@rhaschke I'm not entirely sure, I haven't seen the rationale to switch to moveit_resources_panda_moveit_config, but that is what I see has happened in moveit/moveit2_tutorials#61.

My guess is that panda_moveit_config is meant to be kept as indifferent from tutorials (e.g. moveit tutorial) while tutorials writes may want to add things that a moveit_config package doesn't contain (e.g. I'm seeing perception tutorial moveit/moveit2_tutorials#700 in moveit adds sensor configs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants