Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API: JumpThreshold -> CartesianPrecision #611

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Update API: JumpThreshold -> CartesianPrecision #611

merged 3 commits into from
Sep 17, 2024

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Sep 2, 2024

This should be merged only after the next MoveIt release.

@rhaschke
Adapt API: JumpThreshold -> CartesianPrecision
62ddbe9
@rhaschke
Python: Access properties via writable references
0356a4a 
This allows to modify properties in place, e.g.
cartesian_solver.precision.translational = 0.01
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.63%. Comparing base (6b0f2c8) to head (55b65e0).
Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
core/python/bindings/src/solvers.cpp 68.75% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   58.82%   57.63%   -1.19%     
==========================================
  Files          91      132      +41     
  Lines        8623    10687    +2064     
  Branches        0      962     +962     
==========================================
+ Hits         5072     6158    +1086     
- Misses       3551     4482     +931     
- Partials        0       47      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

v4hn
v4hn approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for my few comments.

Do you really want to keep this lying here until a new moveit release?
I know we went for supporting released and master branch of moveit in the past, but I'm not sure I see the need for it.
Of course we should hold a new release tag until moveit is released as well.

core/src/solvers/cartesian_path.cpp Outdated Show resolved Hide resolved
core/python/bindings/src/solvers.cpp Outdated Show resolved Hide resolved
core/include/moveit/task_constructor/solvers/cartesian_path.h Outdated Show resolved Hide resolved
@v4hn
Copy link
Contributor

v4hn commented Sep 4, 2024

Thanks for addressing the feedback. 👍

Do you really want to keep this lying here until a new moveit release? I know we went for supporting released and master branch of moveit in the past, but I'm not sure I see the need for it. Of course we should hold a new release tag until moveit is released as well.

What's your plan for this? I would merge here if not for your statement above.

@rhaschke
Copy link
Contributor Author

rhaschke commented Sep 4, 2024

What's your plan for this? I would merge here if not for your statement above.

I prefer to have a MoveIt release. Otherwise we enforce people to build from source.
I am happy to cut a new MoveIt release the next days, if there are no objections.

@rhaschke rhaschke merged commit 99ccc11 into moveit:master Sep 17, 2024
7 checks passed
@rhaschke rhaschke deleted the cartesian-precision branch September 17, 2024 08:59
rhaschke added a commit to ubi-agni/moveit_task_constructor that referenced this pull request Sep 17, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (moveit#611)"
1c4f85e 
This reverts commit 99ccc11.
rhaschke added a commit that referenced this pull request Sep 27, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (#611)"
d700742 
This reverts commit 99ccc11.
rhaschke added a commit that referenced this pull request Sep 27, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (#611)"
d7aa99e 
This reverts commit 99ccc11.
cambel added a commit to omron-sinicx/moveit_task_constructor that referenced this pull request Oct 10, 2024
@cambel
Revert "Update API: JumpThreshold -> CartesianPrecision (moveit#611)"
ef42779 
This reverts commit 99ccc11.
rhaschke added a commit to ubi-agni/moveit_task_constructor that referenced this pull request Oct 15, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (moveit#611)"
f2e0ab2 
This reverts commit 99ccc11.
rhaschke added a commit to ubi-agni/moveit_task_constructor that referenced this pull request Oct 15, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (moveit#611)"
2a46993 
This reverts commit 99ccc11.
rhaschke added a commit to ubi-agni/moveit_task_constructor that referenced this pull request Oct 15, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (moveit#611)"
73e616d 
This reverts commit 99ccc11.
rhaschke added a commit to ubi-agni/moveit_task_constructor that referenced this pull request Oct 15, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (moveit#611)"
b61c7e5 
This reverts commit 99ccc11.
rhaschke added a commit to ubi-agni/moveit_task_constructor that referenced this pull request Oct 15, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (moveit#611)"
521b229 
This reverts commit 99ccc11.
rhaschke added a commit to ubi-agni/moveit_task_constructor that referenced this pull request Oct 15, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (moveit#611)"
cc89625 
This reverts commit 99ccc11.
rhaschke added a commit that referenced this pull request Nov 5, 2024
@rhaschke
Revert "Update API: JumpThreshold -> CartesianPrecision (#611)"
3f211ae 
This reverts commit 99ccc11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v4hn v4hn v4hn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhaschke @codecov-commenter @v4hn