Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change joint_properties_ from std::vector to std::map #110

Open
rhaschke opened this issue Feb 28, 2023 · 0 comments
Open

Change joint_properties_ from std::vector to std::map #110

rhaschke opened this issue Feb 28, 2023 · 0 comments

Comments

@rhaschke
Copy link
Contributor

https://github.com/ros-planning/srdfdom/blob/04c7726f2437d5b09bdc790b64d116057b81a90b/include/srdfdom/model.h#L317
To better reflect actual semantics, this should be changed as follows:

-std::map<std::string, std::vector<JointProperty>> joint_properties_;
+std::map<std::string, std::map<std::string, std::string>> joint_properties_;  // joint name -> (property name -> property value)

@scchow, it would be great if you could tackle this (and file a corresponding PR to the ROS2 branch as well).
@rhaschke rhaschke mentioned this issue Feb 28, 2023
Merged
scchow added a commit to scchow/srdfdom that referenced this issue Mar 16, 2023
@scchow
Refactor joint properties data structure
480120d 
- Addresses moveit#110
- Refactored joint_properties to use a map of maps
  for streamlined access to joint properties
- Removed JointProperty struct as information contained is redundant.
- Updated tests to account for new getJointProperties signature
scchow added a commit to scchow/srdfdom that referenced this issue Mar 16, 2023
@scchow
Refactor joint properties data structure (moveit#110)
3bdef2b 
- Refactored joint_properties to use a map of maps
  for streamlined access to joint properties
- Removed JointProperty struct as information contained is redundant.
- Updated tests to account for new getJointProperties signature
@scchow scchow mentioned this issue Mar 16, 2023
Merged
scchow added a commit to scchow/srdfdom that referenced this issue Mar 16, 2023
@scchow
Refactor joint properties
2d121c0 
- Addresses moveit#110
- Refactored joint_properties to use a map of maps
  for streamlined access to joint properties
- Removed JointProperty struct as information contained is redundant.
- Updated tests to account for new getJointProperties signature
scchow added a commit to scchow/srdfdom that referenced this issue Mar 16, 2023
@scchow
Refactor joint properties
06ccb85 
- Addresses moveit#110
- Refactored joint_properties to use a map of maps
  for streamlined access to joint properties
- Removed JointProperty struct as information contained is redundant.
- Updated tests to account for new getJointProperties signature
@scchow scchow mentioned this issue Apr 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhaschke