Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hgexports: add a check to prevent introducing Git submodules (Bug 1903462) #426

Merged
merged 1 commit into from
Jun 20, 2024
Merged

hgexports: add a check to prevent introducing Git submodules (Bug 1903462) #426

merged 1 commit into from
Jun 20, 2024

Conversation

cgsheeh
Copy link
Member

@cgsheeh cgsheeh commented Jun 20, 2024

Add a check to the DiffAssessor API that prevents introduction of
the .gitmodules file, which tracks Git submodules in the repository.

@cgsheeh
hgexports: add a check to prevent introducing Git submodules (Bug 190…
cc81ef2 
…3462)

Add a check to the `DiffAssessor` API that prevents introduction of
the `.gitmodules` file, which tracks Git submodules in the repository.
zzzeid
zzzeid approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@zzzeid zzzeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds yet another for loop that iterates over self.parsed_diff that ultimately checks filenames. I assume this will be addressed in the future PR that you hinted at elsewhere.

@cgsheeh cgsheeh merged commit ef7e3ba into main Jun 20, 2024
1 check passed
@cgsheeh
Copy link
Member Author

cgsheeh commented Jun 20, 2024

This adds yet another for loop that iterates over self.parsed_diff that ultimately checks filenames. I assume this will be addressed in the future PR that you hinted at elsewhere.

Yes, my next 1-2 PRs for the hooks migration should address this.

@cgsheeh cgsheeh deleted the hook-prevent-submodules branch June 20, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzeid zzzeid zzzeid approved these changes

@ahochheiden ahochheiden Awaiting requested review from ahochheiden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgsheeh @zzzeid