mocks: respect limit parameter in mock Conduit API endpoints (Bug 1927013)
#440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…927013) The `PhabricatorDouble` mock API calls take the `limit` parameter, but do not actually limit the number of entries in the response data. Add a check if `limit` is set and slice the `items `list at that index.
shtrom
approved these changes
Oct 25, 2024
Yes, we should probably support the cursor methods as well. It's slightly more involved since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PhabricatorDoublemock API calls take thelimitparameter,but do not actually limit the number of entries in the response data.
Add a check if
limitis set and slice theitemslist at that index.