Add branch names for pushes on non-default branches #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glandium
suggested changes
Sep 20, 2017
| @@ -63,6 +63,8 @@ def add_changeset(self, cs): | |||
| 'desc': cs['desc'], | |||
| 'is_backout': bool(BACKOUT_RE.match(cs['desc'])), | |||
| }) | |||
| if cs.get('branch'): | |||
| self.changesets[-1]['branch'] = cs['branch'] | |||
There was a problem hiding this comment.
Theoretically speaking, a push could have multiple changesets all on different branches. So the branch should be attached to all changesets. Then when creating the bugzilla message, some kind of per branch aggregation should occur.
So a bugzilla message could look like:
Pushed by [email protected] on the branch foo:
https://server/repo/rev/6e4e7985aba3
Foo
https://server/repoa/rev/1234567890ab
Bar
Pushed by [email protected] on the branch qux:
https://server/repoa/rev/234567890abc
Qux
Or some other variation where branches are not repeated. Typical pushes would only have something like the first half.
|
Not sure if the complicated branch_info assignment is worth it just to word the default branch slightly differently. Or maybe it should just be could also do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I did the right thing with the BugInfo.add_changeset