Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Disable "null" toast #1219

Closed
aero31aero opened this issue Sep 4, 2020 · 30 comments · Fixed by #1224
Closed

Disable "null" toast #1219

aero31aero opened this issue Sep 4, 2020 · 30 comments · Fixed by #1224
Labels
defect Issue describes a defect that negatively impacts use.

Comments

@aero31aero
Copy link

Steps to reproduce

  • Set Lockwise as Autofill Provider on Android 11
  • Tap on a textbox that doesn't need Autofill (I'm not sure on this part, happens on a lot of textboxes).

Expected behavior

Nothing happens

Actual behavior

A toast appears with text "null".

Device & build information

  • Device: Pixel 2 XL (taimen)
  • Build version: 4.0.1

Notes

Another person could reproduce it at https://www.reddit.com/r/android_beta/comments/hs0d6k/null_toast/fyqnoox

Attachments:

@aero31aero aero31aero added the defect Issue describes a defect that negatively impacts use. label Sep 4, 2020
@GlenMerlin
Copy link

GlenMerlin commented Sep 8, 2020

Can reproduce

Pixel 4 Android 11 stable
build version 4.0.1

only happens when lockwise is the currently selected autofill app

best apps I've found to test with consistent results are
Signal Private Messenger 4.70.5
Firefox Android 80.1.2
Instagram (Direct Messaging) 157.0.0.37.120

Note: the toast itself is coming from android system but due to it only happening when lockwise is the default I'm led to believe something is erroring with android 11

@caeci11ius
Copy link

Confirmed occurs with lockwise as autofill provider, does not occur when provider changed to google. Problem comes back when lockwise selected again.

@AMonreale
Copy link

Same thing here, Pixel 3a with Android 11. Authy seems the more consistent app showing this toast.

@nsghub
Copy link

nsghub commented Sep 9, 2020

Same here on Pixel 3a and Android 11. Pretty anoying.

@rickhall
Copy link

rickhall commented Sep 9, 2020

Same issue for me on my Pixel 4XL...I'll have to check on my Pixel 4a later. For me, I can easily reproduce it by going into the Messages app and entering any conversation. Every time I enter any conversation, I get a "null" popup message.

@teopb
Copy link

teopb commented Sep 9, 2020

Happens on pixel 4a updated to android 11 today.

@marcomg
Copy link

marcomg commented Sep 9, 2020

Some issue with a pixel 3a with Android 11!

@oniGino
Copy link

oniGino commented Sep 11, 2020

Confirmed on pixel 2 w/android 11

@blitz
Copy link

blitz commented Sep 20, 2020

Same here with a Pixel 3a and Android 11.

@eliserichards Do you someone who can take a look?

@LRomuloux
Copy link

same issue. Pixel 2 Android 11.

severinrudie added a commit to severinrudie/lockwise-android that referenced this issue Sep 21, 2020
severinrudie added a commit to severinrudie/lockwise-android that referenced this issue Sep 21, 2020
severinrudie added a commit to severinrudie/lockwise-android that referenced this issue Sep 22, 2020
severinrudie added a commit to severinrudie/lockwise-android that referenced this issue Sep 22, 2020
@JoeCactus
Copy link

Replicated on Pixel 3a XL, 4.02 not yet available on Play Store for me.

@blitz
Copy link

blitz commented Sep 26, 2020

@baron-severin @eliserichards Thank you so much for fixing this! 🚀

@rahan-crao
Copy link

Is it possible to publish a version with this fix on the Play Store ? It's been more than two weeks the fix is committed...

@oniGino
Copy link

oniGino commented Oct 9, 2020

Mozilla has pretty much abandoned this app and notes and others, who knows when they will get to pushing this

@rahan-crao
Copy link

I just made an APK because I can't wait anymore:
https://drive.google.com/file/d/1pu96SQ8QkqRqMNU1p_ERdraiB-lZrXNT/view?usp=sharing

Disclaimer:

  • use it at your own risk
  • you must uninstall Lockwise before installing the APK
  • you will not receive Lockwise update anymore from the Play Store since it is an external APK

@GlenMerlin
Copy link

This is taking mozilla so long to just push it too the playstore I decided to switch over to bitwarden its a shame

@constructor-s
Copy link

constructor-s commented Oct 16, 2020

I just made an APK because I can't wait anymore:
https://drive.google.com/file/d/1pu96SQ8QkqRqMNU1p_ERdraiB-lZrXNT/view?usp=sharing

Disclaimer:

  • use it at your own risk
  • you must uninstall Lockwise before installing the APK
  • you will not receive Lockwise update anymore from the Play Store since it is an external APK

Sorry if I missed the build instructions but @rahan-crao how did you build it? Just clone in Android Studio and build the release version? No additional modification/external files/libraries required?

@rahan-crao
Copy link

Sorry if I missed the build instructions but @rahan-crao how did you build it? Just clone in Android Studio and build the release version? No additional modification/external files/libraries required?

Android SDK 28 must be installed on your computer. I launched gradlew.bat which downloaded all dependencies. After the I used Android Studio to build the APK. Don't update the gradle plugin with Android Studio, otherwise you will not be able to build Lockwise any more.

@caeci11ius
Copy link

caeci11ius commented Oct 16, 2020

Just a suggestion while everyone is waiting for this to roll out.

Just disable lockwise autofill in the auto-fill service page of settings (you can search, or find it under system > languages and input). The Firefox internal autofill still works fine for websites, so you'll only lose autofill in apps. You can manually copy password from lockwise for these. Sure, if you're regularly logging in and out of apps this will be annoying, but if you're like me, most of your logins will be to websites and unaffected. At least you'll be rid of the annoying toast popup in the meantime, and it's easy to turn it back on when the update finally rolls out.

@Cubox
Copy link

Cubox commented Oct 22, 2020

It has been a month since the issue was fixed in this repo. There is no APK available through the releases section of this repo, nor any updates through the Play Store.

@eliserichards Is there any reason for this delay? All the Android 11 users of Lockwise would love to get the updated code. Thanks in advance

@Cubox
Copy link

Cubox commented Nov 11, 2020

I have sent an email to the lockwise support email.

We’ve received your support request and opened a ticket (11818). We are processing your request.

I hope that'll help get someone on the team to just build a release

@rickhall
Copy link

The sad part is, LockWise is one of the more useful and important things Mozilla has released in a while. If it dies, I will be pretty bummed. Apparently, the writing is on the wall.

@ghost
Copy link

ghost commented Nov 14, 2020

The app was last updated June 29th 2020 according to the playstore. Is it completely abandoned?

@kabel
Copy link

kabel commented Nov 15, 2020

Sure, it stinks if Moz abandons releases to the play store, but we're lucky enough that it's open source and we have awesome community members like @rahan-crao who are willing to publish test binary builds that have the fix.

Patience as always, lest you're one of the lucky ones with a Mozilla insider or support contract. Just keep adding your +1's and we'll keep the spam notifications down while still showing our interest in seeing this fixed and released.

@Cubox
Copy link

Cubox commented Nov 15, 2020

I have sent a tweet to the Mozilla Twitter account, and sent messages through Matrix (chat.mozilla.org) on the general channel and the lockwise channel, to raise awareness of the need for a new release.
EDIT: Also sent tweets to Mozilla Corp CEO, Mozilla Foundation President & Executive Director, Executive VP, VP of Firefox Desktop

@Webbeh
Copy link

Webbeh commented Nov 15, 2020

I compiled a version of it with the null toast problem fixed.

Since I had to self sign this Apk, it is blocked by play protect (they don't know my certificate). You will have to do a full install (remove the previous version) for it to install.

Edit: wait a minute, uploaded the wrong apk...

@Cubox
Copy link

Cubox commented Nov 15, 2020

When the application signature changes key, the application won't update in place and requires a reinstall. That's normal and not due to Play Protect

Also, when you generate those APKs, make sure they are the release mode, and not the debug one. That requires the creation of a keystore, which is not needed for debug variants.
If on login you see something like "USE TEST DATA" in red at the bottom of the app, that's debug mode.

@Webbeh
Copy link

Webbeh commented Nov 15, 2020 via email

@Webbeh
Copy link

Webbeh commented Nov 15, 2020

https://geeq.ch/index.php/s/FbRft7AEydgLAMc

Let me insist that this is self signed and will be reported as untrusted source, and you will need to uninstall the current Lockwise first.

@st3fan
Copy link
Contributor

st3fan commented Nov 15, 2020

I just filed the following issue to get 4.0.2 out of the door. #1239

@mozilla-lockwise mozilla-lockwise locked as resolved and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Issue describes a defect that negatively impacts use.
Projects
None yet
Development

Successfully merging a pull request may close this issue.