Skip to content

Commit

Permalink
temp run on PRs
Browse files Browse the repository at this point in the history
  • Loading branch information
JohanLorenzo committed May 26, 2020
1 parent 317d7b2 commit 4e98c00
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 111 deletions.
88 changes: 1 addition & 87 deletions l10n-screenshots-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,92 +4,6 @@ locales:
- anp
- ar
- ast
- az
- bg
- bn
- bo
- br
- bs
- ca
- co
- cs
- cy
- da
- de
- dsb
- el
- en-CA
- en-GB
- en-US
- eo
- es-AR
- es-CL
- es-MX
- es
- eu
- fa
- fi
- fr
- ga-IE
- gd
- gl
- gu-IN
- he
- hi-IN
- hr
- hsb
- hu
- hy-AM
- ia
- id
- is
- it
- ja
- jv
- ka
- kab
- kk
- km
- kn
- ko
- lo
- lt
- lv
- ml
- mr
- ms
- my
- nb-NO
- ne-NP
- nl
- nn-NO
- oc
- or
- pa-IN
- pl
- pt-BR
- pt-PT
- rm
- ro
- ru
- ses
- si
- sk
- sl
- sq
- su
- sv-SE
- ta
- te
- th
- tl
- tr
- uk
- ur
- uz
- vi
- zgh
- zh-CN
- zh-TW
locales-with-shorter-context-menu: ["hi-IN", "th", "zh-CN", "zh-TW"] # These locales have 1 less screenshot.
locales-with-shorter-context-menu: ["hi-IN", "th", "zh-CN", "zh-TW"] # These locales have 1 less screenshot.
usual-number-of-screenshots: 55
33 changes: 11 additions & 22 deletions taskcluster/ffios_taskgraph/transforms/bitrise.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,26 +20,13 @@ def set_run_config(config, tasks):
run.setdefault("using", "run-commands")
run.setdefault("use-caches", False)

run["secrets"] = {
"by-level": {
"3": [{
"name": "project/mobile/firefox-ios/bitrise",
"key": "api_key",
"path": ".bitrise_token",
}],
"default": [],
},
}

run["dummy-secrets"] = {
"by-level": {
"3": [],
"default": [{
"content": "faketoken",
"path": ".bitrise_token",
}],
},
}
run["secrets"] = [{
"name": "project/mobile/firefox-ios/bitrise",
"key": "api_key",
"path": ".bitrise_token",
}]

run["dummy-secrets"] = []

yield task

Expand Down Expand Up @@ -84,8 +71,10 @@ def add_bitrise_command(config, tasks):
"python3",
"taskcluster/scripts/bitrise-schedule.py",
"--token-file", ".bitrise_token",
"--branch", config.params["head_ref"],
"--commit", config.params["head_rev"],
# "--branch", config.params["head_ref"],
# "--commit", config.params["head_rev"],
"--branch", "master",
"--commit", "8abdd6fb856ebd69f7ca2862b46b150da31c5693",
"--workflow", workflow,
"--artifacts-directory", _ARTIFACTS_DIRECTORY
]
Expand Down
3 changes: 1 addition & 2 deletions taskcluster/scripts/check-screenshots.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ def _check_files(artifacts_directory, locales, number_of_screenshots_per_locale)
if errors:
error_list = "\n * ".join(errors)
log.critical("Got {} error(s) while verifying screenshots: \n * {}".format(len(errors), error_list))
# TODO Uncomment the next line once screenshot tests are fixed on all locales.
# sys.exit(_FAILURE_EXIT_CODE)
sys.exit(_FAILURE_EXIT_CODE)

log.info("No archive is missing and all of them contain the right number of screenshots!")

Expand Down
7 changes: 7 additions & 0 deletions try_task_config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"parameters": {
"optimize_target_tasks": true,
"target_tasks_method": "l10n_screenshots"
},
"version": 2
}

0 comments on commit 4e98c00

Please sign in to comment.