Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache sponsored tile favicons for use elsewhere in the app #22123

Open
data-sync-user opened this issue Sep 20, 2024 · 0 comments
Open

Cache sponsored tile favicons for use elsewhere in the app #22123

data-sync-user opened this issue Sep 20, 2024 · 0 comments

Comments

@data-sync-user
Copy link
Collaborator

Currently, we cache the bundled DefaultSuggestedSites + Google tile favicon after first use so subsequent visits to these sites will also use our high quality icon.

It appears that maybe the SponsoredTiles are not using the same logic, as per this bug: https://github.com/mozilla-mobile/firefox-ios/issues/22098 and this bug: https://github.com/mozilla-mobile/firefox-ios/issues/22109

However the issue may be in hero images or the overlay. Some investigation needs to be done, and maybe an optimization can be made so these sponsored websites have consistent good treatment.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant