Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings colours not correct when changing theme #5616

Closed
dnarcese opened this issue Oct 16, 2019 · 1 comment
Closed

Settings colours not correct when changing theme #5616

dnarcese opened this issue Oct 16, 2019 · 1 comment
Assignees
@dnarcese
Labels
3 Story size

Comments

@dnarcese
Copy link
Contributor

dnarcese commented Oct 16, 2019 •
edited
Loading

The Settings item arrows and the press item colour are not correct if app theme is manually set to the opposite of the system theme.

STR

  1. Change system theme to Dark
  2. Change app theme to Light manually
  3. Observe settings screen
    IMG_5687C897C761-1

Notice the arrows are barely noticeable and when clicking on an item, the background is dark.

Build: 20.0 Beta (16410)
@rockarts
Copy link
Contributor

Fix for this should be similar to #5518 (comment)

@dnarcese dnarcese self-assigned this Oct 28, 2019
@athomasmoz athomasmoz added the 3 Story size label Oct 29, 2019
dnarcese added a commit to dnarcese/firefox-ios that referenced this issue Oct 29, 2019
@dnarcese
Issue mozilla-mobile#5616: Use custom accessoryView for settings
e3c2844
dnarcese added a commit to dnarcese/firefox-ios that referenced this issue Oct 31, 2019
@dnarcese
Fix mozilla-mobile#5616: Add custom selected highlight colour for set…
e44b7e6 
…tings
@cscgh cscgh mentioned this issue Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnarcese dnarcese

Labels
3 Story size
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rockarts @dnarcese @athomasmoz