Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10004 [Toolbar redesign] Fix address toolbar bottom borders on scroll #22079

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Bugfix FXIOS-10004 [Toolbar redesign] Fix address toolbar bottom borders on scroll #22079

merged 3 commits into from
Sep 19, 2024

Conversation

MattLichtenstein
Copy link
Collaborator

@MattLichtenstein MattLichtenstein commented Sep 19, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Always show address toolbar bottom border when scrolling down (even from a negative scroll offset)

📹 Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-09-18.at.23.00.11.mp4

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@MattLichtenstein MattLichtenstein requested a review from a team as a code owner September 19, 2024 02:57
MattLichtenstein
MattLichtenstein commented Sep 19, 2024
View reviewed changes
firefox-ios/Client/Frontend/Browser/Toolbars/Redux/ToolbarMiddleware.swift
Comment on lines -240 to -243
let needsAddressToolbarUpdate = toolbarState.addressToolbar.borderPosition != addressBorderPosition

guard needsAddressToolbarUpdate else { return }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer need this check because now we only dispatch the action when the toolbar borders need updating

thatswinnie
thatswinnie reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@thatswinnie thatswinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for optimizing this! 🎉

There is still an issue where the border would be shown after the user taps on a link of a scrolled website but we can address this in another ticket as well.

firefox-ios/Client/Frontend/Browser/TabScrollController.swift Outdated Show resolved Hide resolved
firefox-ios/Client/Frontend/Home/HomepageViewController.swift Show resolved Hide resolved
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 31.31%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 29.81

File Coverage
HomepageViewController.swift 36.56% ⚠️
TabScrollController.swift 65.58% ✅
ToolbarMiddleware.swift 9.76% ⚠️

Generated by 🚫 Danger Swift against 5a4fd03

@MattLichtenstein MattLichtenstein merged commit 8ee8763 into main Sep 19, 2024
10 checks passed
@MattLichtenstein MattLichtenstein deleted the ml/FXIOS-10004_address-toolbar-border-on-scroll branch September 19, 2024 16:47
@MattLichtenstein MattLichtenstein mentioned this pull request Sep 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

@PARAIPAN9 PARAIPAN9 Awaiting requested review from PARAIPAN9 PARAIPAN9 is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattLichtenstein @mobiletest-ci-bot @thatswinnie