Bugfix MTE-2547 Use the latest version of PyFxA and pytest-fxa

[clarmso]

📜 Tickets

Jira ticket

💡 Description

The Sync Integration Tests have been failing since March 2024 due to an API change in account deletion: Since then the destroy_account API requires a token. Such a change caused the Mozilla accounts that were created during test execution cannot be removed at test tearDown(). The logs of the test run shows the following error:

E           fxa.errors.ClientError: Invalid authentication token: Missing authentication

The latest main (not released yet!) of PyFxA enables us to remove Mozilla accounts using the latest API change. I published the package in PyPI (note "-mte" suffix): https://pypi.org/project/pytest-fxa-mte/

Then I import the PyFxA-mte package to pytest-fxa-mte. pytest-fxa-mte is published in PyPI: https://test.pypi.org/project/pytest-fxa-mte/.

Finally, I pinned the version of pytest-fxa-mte as a part of the dependencies of Sync Integration Tests. 🎉

I have tested my changes using the following command:

pipenv install
pipenv run pytest \
    test_integration.py::test_sync_tabs_from_device \
    test_integration.py::test_sync_tabs_from_desktop \
    test_integration.py::test_sync_bookmark_from_device \
    test_integration.py::test_sync_bookmark_from_desktop \
    test_integration.py::test_sync_history_from_device \
    test_integration.py::test_sync_tabs_from_device \
    test_integration.py::test_sync_history_from_desktop \
    test_integration.py::test_sync_logins_from_desktop \
    test_integration.py::test_sync_tabs_from_desktop \
    test_integration.py::test_sync_disconnect_connect_fxa \
    test_integration.py::test_sync_china_fxa_server \
    --tps ../../../../test-fixtures/tps.xpi \
    --color=yes --junit-xml=results/junit.xml --html=results/index.html

I confirmed that the accounts that were created during the test run no longer exist on stage. The following INFO log is seeen:

INFO     root:plugin.py:60 Removed: FxAccount(email='[email protected]', password='oBApqnXp')

In addition, the following snippet of code is run under the virtualenv of PyFxA to confirm that the account no longer exists.

from fxa.core import Client
client = Client("https://api-accounts.stage.mozaws.net")
client.destroy_account(<email>,<password>)

🤔 Unintentional change: Other dependencies including pytest-html has been bumped. 🤔

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[clarmso]

If we don't like these changes, I can roll back everything except the ones related to pytest-fxa-mte and pyfxa-mte. What do you all think?

Since Pipfile does not pin 📌 particular versions of depdencies, pipenv install bumps the versions.

[AaronMT]

That probably makes sense, you only want changes that reflect changes in this commit.

[clarmso]

See the following published libraries:
https://pypi.org/project/pytest-fxa-mte/
https://pypi.org/project/pyfxa-mte/

[clarmso]

My forks are here:
https://github.com/clarmso/pytest-fxa/tree/1.5.0
https://github.com/clarmso/PyFxA/tree/0.7.9

[clarmso]

I added "do not merge" because I am having Python environment issues on MacStadium.

[clarmso]

I added "do not merge" because I am having Python environment issues on MacStadium.

I have found out that --python 3.12 option must be specified. My versions of the packages were worked on using Python 3.12.

I have tested the command on MacStadium as well.

[AaronMT]

That's great Clare, this looks like the path forward.

For https://pypi.org/project/pytest-fxa-mte/ can you modify the product description to indicate that it's a fork with updates to handling authentication?

Is it safe to drop support for all those older versions of Python in your fork that are mentioned, as it shows in the description on your fork Is that configurable in the PyPi project since you're the maintainer?