Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix - Fix race condition in the redux library #22181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −6
Open

Bugfix - Fix race condition in the redux library #22181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions BrowserKit/Sources/Redux/Store.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,14 @@ public class Store<State: StateType>: DefaultDispatchStore {
}

public func dispatch(_ action: Action) {
guard Thread.isMainThread && !actionRunning else {
DispatchQueue.main.async { [weak self] in self?.dispatch(action) }
return
}

logger.log("Dispatched action: \(action.displayString())", level: .info, category: .redux)

actionRunning = true; defer { actionRunning = false }
DispatchQueue.main.async { [weak self] in
self?.executeAction(action)
}
}

private func executeAction(_ action: Action) {
// Each active screen state is given an opportunity to be reduced using the dispatched action
// (Note: this is true even if the action's UUID differs from the screen's window's UUID).
// Typically, reducers should compare the action's UUID to the incoming state UUID and skip
Expand Down