Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #6107 - Making cover sheet optional per release #6109

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Feature #6107 - Making cover sheet optional per release #6109

merged 2 commits into from
Feb 13, 2020

Conversation

nbhasin2
Copy link
Contributor

Added Top level feature flag per version - Enable / Disable the cover sheet. Eg. We made a change and want to show it as part of cover sheet update. We require setting flag per version. We maintain a list of versions in the app on when to show the coversheet

@mozillamobilebot
Copy link

SwiftLint found issues

Warnings

File Line Reason
UpdateViewModel.swift 35 Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
UpdateViewModel.swift 1 Header comments should be consistent with project patterns. (file_header)
BrowserViewController.swift 447 if, for, guard, switch, while, and catch statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses. (control_statement)
BrowserViewController.swift 1141 if, for, guard, switch, while, and catch statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses. (control_statement)
BrowserViewController.swift 487 Prefer empty collection over optional collection. (discouraged_optional_collection)
BrowserViewController.swift 878 Prefer empty collection over optional collection. (discouraged_optional_collection)
BrowserViewController.swift 1381 Prefer empty collection over optional collection. (discouraged_optional_collection)
BrowserViewController.swift 2421 Force casts should be avoided. (force_cast)
BrowserViewController.swift 2154 Don't add a space between the method name and the parentheses. (no_space_in_method_call)
BrowserViewController.swift 46 Variables should not have redundant type annotation (redundant_type_annotation)
BrowserViewController.swift 2153 Variables should not have redundant type annotation (redundant_type_annotation)

Generated by 🚫 Danger

@nbhasin2 nbhasin2 merged commit 05c22f4 into mozilla-mobile:master Feb 13, 2020
@nbhasin2 nbhasin2 deleted the nb/6107-Coversheet_Optional_Per_Release branch February 13, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants