Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #6522 - XCUITests update homepage label #6523

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion XCUITests/HomePageSettingsUITest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ class HomePageSettingsUITests: BaseTestCase {
enterWebPageAsHomepage(text: websiteUrl1)
waitForValueContains(app.textFields["HomeAsCustomURLTextField"], value: "mozilla")
navigator.goto(SettingsScreen)
XCTAssertEqual(app.tables.cells["Home"].label, "Home, Firefox Home")
XCTAssertEqual(app.tables.cells["Home"].label, "Home, Homepage")
//Switch to FXHome and check label
navigator.performAction(Action.SelectHomeAsFirefoxHomePage)
navigator.nowAt(HomeSettings)
Expand Down
4 changes: 2 additions & 2 deletions XCUITests/NewTabSettings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ class NewTabSettingsTest: BaseTestCase {
app.textFields["NewTabAsCustomURLTextField"].typeText(websiteUrl)
waitForValueContains(app.textFields["NewTabAsCustomURLTextField"], value: "mozilla")
navigator.goto(SettingsScreen)
//Assert that the label showing up in Settings is equal to the URL entere (NOT CURRENTLY WORKING, SHOWING HOMEPAGE INSTEAD)
XCTAssertEqual(app.tables.cells["NewTab"].label, "New Tab, Firefox Home")
//Assert that the label showing up in Settings is equal to the URL entered (NOT CURRENTLY WORKING, SHOWING HOMEPAGE INSTEAD)
XCTAssertEqual(app.tables.cells["NewTab"].label, "New Tab, Homepage")
//Switch to Blank page and check label
navigator.performAction(Action.SelectNewTabAsBlankPage)
navigator.nowAt(NewTabSettings)
Expand Down
1 change: 1 addition & 0 deletions XCUITests/ThirdPartySearchTest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ class ThirdPartySearchTest: BaseTestCase {
let customengineurlTextView = tablesQuery.textViews["customEngineUrl"]
customengineurlTextView.staticTexts["URL (Replace Query with %s)"].tap()
customengineurlTextView.press(forDuration: 1.0)
waitForExistence(app.staticTexts["Paste"], timeout: 5)
app.staticTexts["Paste"].tap()
sleep(2)
app.navigationBars.buttons["customEngineSaveButton"].tap()
Expand Down