Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

disable the full UX flow test until PR 101 lands #107

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

rhelmer
Copy link
Contributor

@rhelmer rhelmer commented Aug 31, 2021

No description provided.

@rhelmer rhelmer self-assigned this Aug 31, 2021
@rhelmer rhelmer requested a review from Carla-Moz August 31, 2021 21:30
Copy link
Contributor

@Carla-Moz Carla-Moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still failing on my local which I'm not sure why since they passed in CircleCi. Can you see if you can reproduce on your end? I'm sure I'm on the right branch and have the latest.

`FAIL tests/integration/ux.test.ts (10.753 s)
Rally Web Platform extension interop
✕ fails to sign up for a new email account with invalid info (3091 ms)
✕ fails to sign into website with invalid email credentials (2326 ms)
✓ signs up for website with valid email credentials (2644 ms)
✕ fails to sign into website with invalid credentials (2009 ms)

● Rally Web Platform extension interop › fails to sign up for a new email account with invalid info

InvalidArgumentError: binary is not a Firefox executable

  at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:517:15)
  at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:642:13)
  at Executor.execute (node_modules/selenium-webdriver/lib/http.js:568:28)`

@rhelmer
Copy link
Contributor Author

rhelmer commented Aug 31, 2021

Tests are still failing on my local which I'm not sure why since they passed in CircleCi. Can you see if you can reproduce on your end? I'm sure I'm on the right branch and have the latest.

`FAIL tests/integration/ux.test.ts (10.753 s)
Rally Web Platform extension interop
✕ fails to sign up for a new email account with invalid info (3091 ms)
✕ fails to sign into website with invalid email credentials (2326 ms)
✓ signs up for website with valid email credentials (2644 ms)
✕ fails to sign into website with invalid credentials (2009 ms)

● Rally Web Platform extension interop › fails to sign up for a new email account with invalid info

InvalidArgumentError: binary is not a Firefox executable

  at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:517:15)
  at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:642:13)
  at Executor.execute (node_modules/selenium-webdriver/lib/http.js:568:28)`

Hm, which OS is this? Do you have Firefox Nightly installed? I can improve that error message, one moment.

@rhelmer
Copy link
Contributor Author

rhelmer commented Aug 31, 2021

@Carla-Moz oh actually you know what, per our conversation earlier today we don't really need to use Firefox Nightly anymore, that is leftover from when we needed special privileges in the core add-on. I'll just make the test use the standard Firefox release, that should be less hassle.

@rhelmer rhelmer requested a review from Carla-Moz August 31, 2021 23:07
Copy link
Contributor

@Carla-Moz Carla-Moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end!

@rhelmer rhelmer merged commit 5190d6a into mozilla-rally:master Sep 1, 2021
Carla-Moz pushed a commit to Carla-Moz/rally-web-platform that referenced this pull request Sep 2, 2021
* disable the full UX flow test until PR 101 lands

* remove redundant command

* remove firefox nightly support, just use release
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants