Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

onPageTransitionData doesn't correctly report referrer #290

Closed
akohlbre opened this issue Jul 13, 2022 · 1 comment
Closed

onPageTransitionData doesn't correctly report referrer #290

akohlbre opened this issue Jul 13, 2022 · 1 comment
Assignees
@akohlbre

Comments

@akohlbre
Copy link
Contributor

Transitions mentions that the details for onPageTransitionData includes the referrer, and it does try to grab it, but the event coming out of the content script doesn't actually report it, so it always comes out blank in details.
@akohlbre akohlbre self-assigned this Jul 13, 2022
akohlbre added a commit that referenced this issue Jul 13, 2022
@akohlbre
add referrer to transitions event, fixing #290
74a1c77
@jonathanmayer
Copy link
Contributor

Could you please use pageManager.referrer instead of document.referrer for consistency with the Page Navigation content script? Otherwise LGTM, thanks!

jonathanmayer added a commit that referenced this issue Jul 13, 2022
@jonathanmayer
Merge pull request #291 from mozilla-rally/issue290
22a3137 
add referrer to transitions event, fixing #290
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@akohlbre akohlbre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanmayer @akohlbre