fixes issue #284, use new cross-browser scripting api for registering… #301
Conversation
Bumps [shell-quote](https://github.com/substack/node-shell-quote) from 1.7.2 to 1.7.3. - [Release notes](https://github.com/substack/node-shell-quote/releases) - [Changelog](https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md) - [Commits](https://github.com/substack/node-shell-quote/compare/v1.7.2...1.7.3) --- updated-dependencies: - dependency-name: shell-quote dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
… content scripts
rhelmer
force-pushed
the
switch-to-scripting-api
branch
from
1dbe119
to
a8dcdf1
Compare
rhelmer
force-pushed
the
switch-to-scripting-api
branch
from
d66191f
to
a7b9a7b
Compare
rhelmer
force-pushed
the
switch-to-scripting-api
branch
from
4fd9ff2
to
75f8515
Compare
|
Another thing we should address: it might be worth it to add a "Chrome/MV3 support" column to that modules table in the README? since it seems we'll be updating these modules piecemeal as and when we need them. Doesn't necessarily need to be in the scope of this PR, but just wanted to put it on the radar as something that would be useful to consumers of this library (primarily future us!). |
Good idea, did this as well... I made it a single "Browser Support" column with the text "Firefox" and/or "Chrome", we could use browser icons later if we add more and need to save space, but this seemed simpler and more readable. |
… content scripts
Review expectations: this has integration tests for Firefox (mv2) and Chrome (mv3), so I think just a visual check is OK. If you'd like to try loading this into an extension or load the test extension into your browser that's fine too (but probably redundant with the integration test).