Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUT-161 - de-globalizing unit tests. Also removed parallelism #968

Merged
merged 2 commits into from
Sep 3, 2024
Merged

AUT-161 - de-globalizing unit tests. Also removed parallelism #968

merged 2 commits into from
Sep 3, 2024

Conversation

alexcottner
Copy link
Contributor

@alexcottner alexcottner commented Aug 30, 2024 •
edited
Loading

AUT-161 - de-globalizing unit tests.
Also removed parallelism to prevent parallel database calls trying to do the same thing.
Still on the fence on adding a test framework that would give us a little more structure.

alexcottner
alexcottner commented Aug 30, 2024
View reviewed changes
main_test.go Outdated Show resolved Hide resolved
@alexcottner alexcottner marked this pull request as ready for review August 30, 2024 15:55
@alexcottner alexcottner requested review from a team as code owners August 30, 2024 15:55
@alexcottner alexcottner requested review from jmhodges and removed request for a team August 30, 2024 15:55
jmhodges
jmhodges requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@jmhodges jmhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a good patch that is giving us an accurate representation of what we should be testing.

One question about deleting data in the database and I would like the name change, too. (if you hate my suggestions I'm happy to let go of it).

main_test.go Outdated Show resolved Hide resolved
@alexcottner alexcottner merged commit 869ae50 into main Sep 3, 2024
14 checks passed
@alexcottner alexcottner deleted the bug-161 branch September 6, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhodges jmhodges jmhodges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcottner @jmhodges