emit request URI in signature handler response log #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log entries for the signature handler response don't include the exact kind of API call it was in them, making it hard to suss out who is doing certain kinds of traffic. I was looking to see how was making the tens of /sign/hash requests we see in production that I saw in the metrics, and couldn't easily correlate them to the logs to figure out which users were in play. This would be better as a tracing set up, but Mozilla doesn't have the observability platform for that right now.
jmhodges
force-pushed
the
request-uri-in-logs
branch
from
814db58
to
846407e
Compare
bhearsum
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log entries for the signature handler response don't include the
exact kind of API call it was in them, making it hard to suss out who is
doing certain kinds of traffic.
I was looking to see how was making the tens of /sign/hash requests we
see in production that I saw in the metrics, and couldn't easily
correlate them to the logs to figure out which users were in play.
This would be better as a tracing set up, but Mozilla doesn't have the
observability platform for that right now.