AUT-184: install Google's libkmsp11 into autograph docker image #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbuck
reviewed
Sep 11, 2024
Note that the AWS one that we currently use is mounted into the container at runtime. That will naturally stop happening in GCP, as our infra code is brand new, so no down the road cleanup will be needed.
jbuck
approved these changes
Sep 11, 2024
jmhodges
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the AWS one that we currently use is mounted into the container at runtime. That will naturally stop happening in GCP, as our infra code is brand new, so no down the road cleanup will be needed.
I've started a companion branch in the config repo to go along with this. It's not complete, but it's a start.