feat: Use CircleCI instead of Travis for tests #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to run its tests
By adding table rotation, the Rust autopush and autoendpoint code select different message tables. Autopush (specifically autopush-common) selects the last alphanumerically sorted message table, whereas autoendpoint uses the exact table name it was given. When running the Python autopush integration tests before the Rust autopush integration tests, the rotated tables would be created and trigger this issue. Since table rotation is no longer used, the tests have been removed/modified to not create the month-specific rotation tables. Also resets the AWS_LOCAL_DYNAMODB env variable if we started our own DynamoDB instance. Also fixes an issue where the create_router_table function did not check if the table already exists. This is fixed by using the get_router_table function.
jrconlin
previously approved these changes
Aug 13, 2020
It contains includes requirements.txt by way of a `-r` command.
jrconlin
previously approved these changes
Aug 14, 2020
jrconlin
force-pushed
the
feat/circleci
branch
from
e1cdcd3
to
112ba3b
Compare
AzureMarker
commented
Aug 18, 2020
pjenvey
approved these changes
Aug 18, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis is no longer used. The tests (including format check) run in parallel alongside the build and audit jobs. Currently, the tests take about 3-7 minutes (depending on cache availability), compared to 22 minutes in Travis.
Some of the changes:
circleci/dynamodb) instead of starting one inside of the tests. Support for using an existing database has been added to the integration test suites (setAWS_LOCAL_DYNAMODB).This also requires a change to the GitHub repo to change from requiring Travis checks to CircleCI.
Closes #148