This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: Avoid installing dependencies as editable #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editable dependencies may be installed in ./src, such as when running on CI. This breaks py.test because the dependency tests are also considered. This issue was seen on autopush-rs when moving the tests to CircleCI.
jrconlin
approved these changes
Aug 12, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Editable dependencies may be installed in ./src, such as when running on CI without a virtual env. This breaks py.test because the dependency tests are also considered (which may have unknown dependencies). This issue was seen on autopush-rs when moving the tests to CircleCI.
Also, the txstatsd dependency was using an incorrect egg name, which caused a warning during install.
Testing
CI passes
Issue(s)
N/A