This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Fix metric calls #1462
Open
bug: Fix metric calls #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Be explicit about args * handle AttributeError gracefully Closes: #CONSVC-1842
pjenvey
suggested changes
Jun 27, 2022
autopush/router/apnsrouter.py
Outdated
| try: | ||
| reason = e.extra.get("reason", "unknown") | ||
| except AttributeError: | ||
| reason = format("Unknown: {}", e) |
There was a problem hiding this comment.
reason here is a metrics tag value which shouldn't have whitespace:
Suggested change
| reason = format("Unknown: {}", e) | |
| reason = "unknown" |
Sentry's complaining about a hyper.common.exceptions.ConnectionResetError, could include it alongside ConnectionError handling above -- if isinstance(e, (ConnectionError, ConnectionResetError)): but probably not even worth the effort.
pjenvey
suggested changes
Jul 13, 2022
There was a problem hiding this comment.
The last update removed the fix for the AttributeError entirely
|
I hate "helpful" merges. |
pjenvey
approved these changes
Jul 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #CONSVC-1842