Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about icon size mismatch if icon is SVG #1669

Closed
asamuzaK opened this issue Nov 24, 2017 · 7 comments
Closed

Don't warn about icon size mismatch if icon is SVG #1669

asamuzaK opened this issue Nov 24, 2017 · 7 comments

Comments

@asamuzaK
Copy link
Contributor

Describe the problem and steps to reproduce it:

(Please include as many details as possible.)
When I uploaded add-on to AMO, it is warned about icon size mismatch.

The size of the icon does not match the manifest.

警告: Expected icon at "icon.svg" to be 32 pixels wide but was 128.

My manifest.json is like this.

  "icons": {
    "32": "icon.svg#gray",
    "64": "icon.svg"
  },

It is an SVG file, so size should not matter.

What happened?

AMO raised warning.

What did you expect to happen?

No warning.

Anything else we should know?

(Please include screenshots and any relevant files.)

In icons - Mozilla | MDN, it is explained as:

Even though you can use one file, you still need to specify various size of the icon in your manifest. E.g.:

"icons": {
  "48": "icon.svg",
  "96": "icon.svg"
}
@erosman
Copy link
Contributor

erosman commented Dec 30, 2017

Was this one fixed and pushed?
The error is still present.

@asamuzaK
Copy link
Contributor Author

In addons-linter, yes.
I don't know it is pushed to AMO server.

@asamuzaK
Copy link
Contributor Author

Latest release seems to be Release 2017.12.07 · mozilla/addons-server but linter is merged on Dec 08, 2017? Comparing 2017.12.07...master · mozilla/addons-server

@asamuzaK
Copy link
Contributor Author

Confirmed fixed on AMO server too.

@AlexandraMoga
Copy link

Tried validating an extension which included .svg icons with wrong sizes defined in the manifest and no errors/warnings were thrown.
Marking this as verified fixed.

@erosman
Copy link
Contributor

erosman commented Jan 28, 2018

There are still warnings ....

https://reviewers.addons.mozilla.org/en-US/firefox/files/browse/817497/

Warning: The size of the icon does not match the manifest.
Expected icon at "images/rikaichamp-blue.svg" to be 48 pixels wide but was 200.

Warning: The size of the icon does not match the manifest.
Expected icon at "images/rikaichamp-blue.svg" to be 96 pixels wide but was 200.

Warning: The size of the icon does not match the manifest.
Expected icon at "images/rikaichamp-blue.svg" to be 128 pixels wide but was 200.

@asamuzaK
Copy link
Contributor Author

There are still warnings ....

https://reviewers.addons.mozilla.org/en-US/firefox/files/browse/817497/

I think you should file a new issue in mozilla/addons-server for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants