fix: prevent Object properties to be detected as existent files by tabs.executeScript rule #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EnTeQuAk it could be nice to have an helper function to use where we check that a filename exists, so that it would be harder to get caught by the subtle differences between using |
…bs.executeScript rule
rpl
force-pushed
the
fix/use-hasOwnProperty-in-executeScript-rule
branch
from
bfe99f2
to
6516c99
Compare
EnTeQuAk
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix a small issue in the rule that checks if the files used in a tabs.executeScript API calls actually exist (even if it is unlikely that an extension would call one of its content script file "constructor", or like other Object properties, the rule is supposed to raise an error if the filename is not an actual property of the existingFiles object).