Usage of 'mozIndexedDB' should be a warning instead of an error #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update r+wc |
|
I get some (seemlingly) unrelated test failures, let's wait for travis... |
|
Afaics, the rules document is correct, just the implementation was wrong. |
|
Right on. A nitpick would be to change the rule from "not allowed" to "discouraged". |
|
I am totally at loss about the test failures. Could you give me a hint? Also, I don't see where it says "not allowed". |
wagnerand
force-pushed
the
mozindexeddb-warning
branch
from
6443bc6
to
9fcee68
Compare
|
Ok, I updated the rule description. |
|
After reviewing this and the tests failures this is r- (not safe to merge) until #798 is fixed. After that it's r+ but I'll have a look at making sure it's all okay and merge it in myself 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #796