Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: mozilla/addons#15028
Description
OLYMPIA_UID
build arg in our docker build that is set to theHOST_UID
ONLY on local buildsDockerfile
to makedevelopment
stage skip all production asset/compilation stepsentrypoint.sh
to check if theolympia
UID matches theHOST_UID
, and if it does not modify the olympia user ID (as before) and additionally modify the directory ownership of/data/olympia
storage
anddata_static
mounts into singledata_olympia
mount shared betweenweb
andnginx
containers.docker-compose.ci.yml
as a redundant configuration file (update relevant CI configs)Context
This PR reconfigures our docker compose setup such that local builds only include the base stage + development dependencies skipping most asset/local/source steps. These steps are somewhat redundant for most development use cases and increase build times. Removing them means smaller, faster local images.
The downside to this is our local image is "missing" things. The rest of the PR is modifying our local setup in a way the ensures the local container includes everything missing from the build and additionally ensures compatibility with remote images.
Our local setup now needs to understand if we are building locally or using a remote image and depending on this will:
Some issues currently with this PR include:
Testing
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.