Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient diff function removing quadratic iterable #22859

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

KevinMind
Copy link
Contributor

Fixes: mozilla/addons#15170

Testing

Automated test should cover it.. the test without sets hangs forever

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

Copy link

sentry-io bot commented Nov 15, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/olympia/blocklist/mlbf.py

Function Unhandled Issue
ordered_diff_lists TypeError: argument of type 'NoneType' is not iterable olympia.blocklist.mlbf in <lis...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

@KevinMind KevinMind requested review from a team and diox and removed request for a team November 15, 2024 11:40
src/olympia/blocklist/tests/test_mlbf.py Outdated Show resolved Hide resolved
@KevinMind KevinMind merged commit ed0cce2 into master Nov 15, 2024
31 checks passed
@KevinMind KevinMind deleted the fix-quadratic-loop branch November 15, 2024 15:23
KevinMind added a commit that referenced this pull request Nov 15, 2024
* More efficient diff function removing quadratic iterable

* fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: upload_mlbf_to_remote_settings hangs on the diff
2 participants