Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an indication of star ratings in the list of all reviews #10358

Closed
kumar303 opened this issue Apr 28, 2017 · 3 comments
Closed

Show an indication of star ratings in the list of all reviews #10358

kumar303 opened this issue Apr 28, 2017 · 3 comments
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@kumar303
Copy link
Contributor

Describe the problem and steps to reproduce it:

  • Go to an add-on detail page that only has one review (entered without text) -- i.e. a star rating.
  • Tap on Read 1 Review

What happened?

You see an indication that there is a review:
screenshot 2017-04-28 15 18 14

but when you tap on the link, you don't see any reviews:
screenshot 2017-04-28 15 17 53

What did you expect to happen?

There should be some indication that these star ratings exist. I don't think we should hide individual star ratings.

Anything else we should know?

@pwalm and/or @jvillalobos do you have any ideas of what should happen here?

Reviews without text are explicitly hidden (also see #4164) but I don't think that's the right thing to do in this case.

Here are some ideas I have:

  • We could list star rating reviews and just not show any text. This would at least avoid confusion and could also show which user left which star rating (dunno if that's helpful)
  • We could show a summary at the top of the list saying something like '5 reviews without text are hidden'
  • At the very least we should make the count of reviews match up -- that will be fixed in Hide empty reviews from the review list because review count is wrong #10357
@jvillalobos
Copy link

I would suggest not showing the link unless there are reviews with text. Maybe we need a different place to say how many ratings were involved to get the average.

@kumar303
Copy link
Contributor Author

kumar303 commented May 2, 2017

I would suggest not showing the link unless there are reviews with text.

Ah, yeah, that's a good place to start. I'll make sure to fix that in #10357

@kumar303
Copy link
Contributor Author

This will be tackled in #11183 and #11184

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

4 participants