Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide empty reviews from the review list because review count is wrong #10357

Closed
kumar303 opened this issue Apr 28, 2017 · 8 comments · Fixed by mozilla/addons-frontend#3893 or mozilla/addons-frontend#3865
Assignees
Labels
Milestone

Comments

@kumar303
Copy link
Contributor

kumar303 commented Apr 28, 2017

Steps to reproduce:

  1. Go to an add-on details page for an add-on that has empty reviews (i.e. https://addons-dev.allizom.org/en-US/firefox/addon/multi-highlight/). An empty review is one where the user has just selected a star but did not enter any text.
  2. In the rating section observe the number of reviews associated with the add-on and then click on 'Read all Reviews'
  3. Once the page loads, verify the actual number of reviews displayed

Expected result:
Number of reviews mentioned in the add-on details page and total reviews form 'All reviews' page are the same

Actual result:
Number of reviews from "All reviews' page is lower than the number mentioned in the details page

inconsistentrew

The textless reviews are currently filtered out in JS but once we have a proper filter (#4304), let's use it. Among other things, this will fix pagination counts.

This fix should also hide the Read N reviews link if there are no reviews with text for the add-on.

@kumar303
Copy link
Contributor Author

I'm adding filter: without_empty_body to the API in #10494 which will partially close this issue. The Read N reviews text is going to require an extra API call though until we can get #4480

@muffinresearch
Copy link
Contributor

#4480 is fixed

@kumar303 kumar303 changed the title Hide empty reviews from the review list with a proper API parameter Hide empty reviews from the review list because review count is wrong Oct 31, 2017
@kumar303 kumar303 self-assigned this Oct 31, 2017
@kumar303 kumar303 added the size:S label Nov 9, 2017
@AlexandraMoga
Copy link

@kumar303 I've tested this on -dev but I couldn't see any changes yet.

See https://addons-dev.allizom.org/en-US/firefox/addon/saerch_my_addons/reviews/

empty reviews

@AlexandraMoga AlexandraMoga reopened this Nov 10, 2017
@kumar303
Copy link
Contributor Author

Auto-updates to the dev server were broken due to a security upgrade on one of our services -- sorry about that. The patch should be on dev now. You can also check the commit hash at this URL and compare it to the commit mentioned in the issue (or check the log).

@AlexandraMoga
Copy link

@kumar303 the review list title is still displaying the total number of reviews for the add-on, not only the number of written reviews. The below add-on has a total number of 6 reviews out of which only 3 are written. Shouldn't the title read "3 reviews for this add-on" in this case?

image

@kumar303
Copy link
Contributor Author

Ah, whoops, I missed that part :) A fix is on the way.

@AlexandraMoga
Copy link

Can't properly verify the last fix until issue described in #3904 is resolved.

@AlexandraMoga
Copy link

Verified as fixed in #3904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants