-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide empty reviews from the review list because review count is wrong #10357
Hide empty reviews from the review list because review count is wrong #10357
Comments
#4480 is fixed |
@kumar303 I've tested this on -dev but I couldn't see any changes yet. See https://addons-dev.allizom.org/en-US/firefox/addon/saerch_my_addons/reviews/ |
Auto-updates to the dev server were broken due to a security upgrade on one of our services -- sorry about that. The patch should be on dev now. You can also check the commit hash at this URL and compare it to the commit mentioned in the issue (or check the log). |
@kumar303 the review list title is still displaying the total number of reviews for the add-on, not only the number of written reviews. The below add-on has a total number of 6 reviews out of which only 3 are written. Shouldn't the title read "3 reviews for this add-on" in this case? |
Ah, whoops, I missed that part :) A fix is on the way. |
Can't properly verify the last fix until issue described in #3904 is resolved. |
Verified as fixed in #3904 |
Steps to reproduce:
Expected result:
Number of reviews mentioned in the add-on details page and total reviews form 'All reviews' page are the same
Actual result:
Number of reviews from "All reviews' page is lower than the number mentioned in the details page
The textless reviews are currently filtered out in JS but once we have a proper filter (#4304), let's use it. Among other things, this will fix pagination counts.
This fix should also hide the Read N reviews link if there are no reviews with text for the add-on.
The text was updated successfully, but these errors were encountered: