Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert search and add-on detail page to sagas #10408

Closed
kumar303 opened this issue May 25, 2017 · 5 comments
Closed

Convert search and add-on detail page to sagas #10408

kumar303 opened this issue May 25, 2017 · 5 comments
Assignees
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@kumar303
Copy link
Contributor

kumar303 commented May 25, 2017

Instead of using async-connect to pre-load the add-on detail page, we should use a saga. As part of this, let's also stop populating the add-on detail page with data from search results because it will fix bugs like https://github.com/mozilla/addons-frontend/issues/2435

Steps to test this for QA:

  • Load the add-on detail page, make sure it works.
  • Try refreshing the detail page, make sure it still works.
  • Try searching for an add-on and navigating to its detail page, make sure it works.
@kumar303
Copy link
Contributor Author

This is a step towards #10365

@kumar303
Copy link
Contributor Author

I moved this to #10479 and #10478 . I'll do the search conversion later once I catch my breath.

@vcarciu
Copy link

vcarciu commented Jun 19, 2017

Verified all scenarios from description and more other around and everything looks fine.
Marking as verified.

@kumar303
Copy link
Contributor Author

whoops, sorry. I closed this because it was invalid but I forgot to change the flags. No code change landed.

@vcarciu
Copy link

vcarciu commented Jun 19, 2017

I will remove the verified label then and verify same scenarios for the other issues. Thanks

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

4 participants