Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate add-on detail views before converting it to saga #10450

Closed
kumar303 opened this issue Jun 5, 2017 · 4 comments · Fixed by mozilla/addons-frontend#2520
Closed

Consolidate add-on detail views before converting it to saga #10450

kumar303 opened this issue Jun 5, 2017 · 4 comments · Fixed by mozilla/addons-frontend#2520
Assignees
@kumar303
Labels
repository:addons-frontend Issue relating to addons-frontend state:verified_fixed
Milestone
2017.06.15

Comments

@kumar303
Copy link
Contributor

kumar303 commented Jun 5, 2017 •
edited
Loading

The add-on detail components needed a lot of cleanup before porting it to a saga so I think it makes sense to land the cleanup patch first. This is in preparation for #10408

For QA: It would be helpful if you could check for regressions on the add-on detail page. Some things to check:

  • Can you install add-ons?
  • Does theme previewing still work?
  • Can you install themes?
  • Does the detail page still look right after the theme is installed?
@kumar303 kumar303 self-assigned this Jun 5, 2017
@kumar303 kumar303 mentioned this issue Jun 5, 2017
Merged
@kumar303
Copy link
Contributor Author

kumar303 commented Jun 7, 2017

It looks like this caused a regression: #10453

@kumar303 kumar303 reopened this Jun 7, 2017
@kumar303
Copy link
Contributor Author

kumar303 commented Jun 7, 2017

Actually, I'm tracking the regression in #10453 so let's just close this since it landed in mozilla/addons-frontend#2520

@kumar303 kumar303 closed this as completed Jun 7, 2017
@vcarciu
Copy link

vcarciu commented Jun 8, 2017

Tried all scenarios from description and some more scenarios around and everything looks fine.
Marking bug as verified.

@kumar303
Copy link
Contributor Author

kumar303 commented Jun 8, 2017

Thanks for taking a look. Keep in mind that the fix for #10453 hasn't on dev landed yet.

@KevinMind KevinMind added migration:no-jira repository:addons-frontend Issue relating to addons-frontend labels May 5, 2024
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumar303 kumar303

Labels
repository:addons-frontend Issue relating to addons-frontend state:verified_fixed
Projects
None yet
Milestone
2017.06.15
Development

Successfully merging a pull request may close this issue.

Consolidate add-on detail views before converting it to saga kumar303/addons-frontend
4 participants
@kumar303 @vcarciu @addons-robot @KevinMind