Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert add-on review list to sagas #10494

Closed
kumar303 opened this issue Jun 19, 2017 · 2 comments · Fixed by mozilla/addons-frontend#2633
Closed

Convert add-on review list to sagas #10494

kumar303 opened this issue Jun 19, 2017 · 2 comments · Fixed by mozilla/addons-frontend#2633
Assignees
Labels
repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@kumar303
Copy link
Contributor

Instead of using async-connect to pre-load data for the add-on review listing, we should use a saga.

Steps to test for regressions:

  • Load an add-on detail page for an add-on that has reviews
  • Click 'Read N reviews'
  • Make sure the review listing still works

This is a step towards #10365

@vcarciu
Copy link

vcarciu commented Jun 27, 2017

@kumar303 : Please let me know if this is ok and will be solved in another issue, or this should be reopened:
reviewsbeforeloading

@kumar303
Copy link
Contributor Author

Hi @vcarciu , your screencast looks right. What were you expecting to happen that should be solved in another issue? Thanks for testing it out.

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants