Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename editors to reviewers internally #4932

Closed
diox opened this issue Oct 23, 2017 · 3 comments · Fixed by mozilla/addons-server#6752
Closed

Rename editors to reviewers internally #4932

diox opened this issue Oct 23, 2017 · 3 comments · Fixed by mozilla/addons-server#6752
Assignees
@diox
Labels
component:reviewer_tools repository:addons-server Issue relating to addons-server state:verified_fixed
Milestone
2017.10.26

Comments

@diox
Copy link
Member

diox commented Oct 23, 2017

In #4830 we'll rename /editors/ to /reviewers/. Before that, we should rename the django app and urls (keeping the tables intact, at least for now).
@diox diox self-assigned this Oct 23, 2017
@diox
Copy link
Member Author

diox commented Oct 23, 2017

Note: this will change the celery queue name, so need to sync up with ops on that.

@diox diox mentioned this issue Oct 23, 2017
Merged
@diox diox added the qa:extra label Oct 23, 2017
@diox
Copy link
Member Author

diox commented Oct 23, 2017

QA: make sure reviewer tools and auto approvals still work fine. All changes here should be internal, everything should still work the same for now (save for a few trivial wording changes).

@diox diox mentioned this issue Oct 24, 2017
Closed
@ValentinaPC
Copy link

ValentinaPC commented Oct 24, 2017 •
edited
Loading

Verified this on AMO-dev FF56(Win 7)

  1. Auto-approval work as expected
  2. Weight is added accordingly
  3. Points for reviewer work as expected
  4. Actions like approve content, reject. etc. work as expected
  5. Normal reviews work as expected
  6. LWT themes approval work as expected
  7. Moderated review actions work as expected
  8. Links from Reviewer Tools redirect as expected
  9. Extensions updates are working as expected

This can be marked as verified-fixed.

This was referenced May 4, 2024
Closed
Merged
@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diox diox

Labels
component:reviewer_tools repository:addons-server Issue relating to addons-server state:verified_fixed
Projects
None yet
Milestone
2017.10.26
Development

Successfully merging a pull request may close this issue.

Rename editors to reviewers everywhere except in the URLs diox/olympia
3 participants
@diox @ValentinaPC @KevinMind