Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reviews to ratings #4937

Closed
4 tasks done
diox opened this issue Oct 24, 2017 · 5 comments · Fixed by mozilla/addons-server#6776
Closed
4 tasks done

Rename reviews to ratings #4937

diox opened this issue Oct 24, 2017 · 5 comments · Fixed by mozilla/addons-server#6776

Comments

@diox
Copy link
Member

diox commented Oct 24, 2017

Both internally and in the API, we should rename reviews to ratings to avoid clashing with reviewers (see #4932). For the API we should keep things backwards-compatible for now.

  • Move the app (and templates, fixtures etc)
  • Change the URL names
  • Change the model names
  • Change functions/methods/classes names (API only)
@milupo
Copy link

milupo commented Oct 30, 2017

I have already proposed this in the following issue:

#3022

It will help translators to differentiate between ratings and checkups which both are still called "review".

@diox
Copy link
Member Author

diox commented Oct 30, 2017

This is a different issue. I completely agree with you, but I'm not planning to change the strings/translations yet.

@diox
Copy link
Member Author

diox commented Nov 6, 2017

I've opened up #4984 to change the API urls, splitting that task into a different issue.

I'm not sure we'll want to take care of the database yet because it has tons of implications (renaming indices, dealing with the fact that some people might have queries saved in redash, etc) so I am not planning to handle that for now.

@diox
Copy link
Member Author

diox commented Nov 13, 2017

QA: the changes in this issue should be completely transparent to end-users. Please verify that posting/editing/listing/moderating user ratings on add-ons still work.

@AlexandraMoga
Copy link

Verified on AMO-dev FF57 (Win 10)
I've taken the following action for user reviews: submitting editing, flagging, posting developer replies, moderating (from Reviewer tools - Moderated reviews queue).
Everything seems to be working as expected, apart for the review counts mentioned in #3904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants