-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a minimum Python version of 3.8 [ci full] #5961
Conversation
I've been seeing these |
The main issue I'm seeing here is that the Mac TC workers likely need to be updated to run 3.8 instead of 3.7. |
d3a63b8
to
6539c14
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5961 +/- ##
=======================================
Coverage 83.81% 83.81%
=======================================
Files 117 117
Lines 15666 15666
=======================================
Hits 13131 13131
Misses 2535 2535 ☔ View full report in Codecov by Sentry. |
6539c14
to
2f10c23
Compare
Made https://bugzilla.mozilla.org/show_bug.cgi?id=1867813 for upgrading the mac worker. |
I feel like we should document this somewhere too? Even if to say that A-S stays in sync with m-c. Does anyone have a suggestion as to where that should go? |
We have https://github.com/mozilla/application-services/blob/main/docs/design/rust-versions.md for our Rust versions (which ends up in https://mozilla.github.io/application-services/book/design/rust-versions.html) We can make that document more general and include Python there or place another document next to it |
8e839a3
to
a9681c3
Compare
dc1439a
to
ca3f1a5
Compare
The minimum Python version was recently bumped to version 3.8 in mozilla-central - see bug 1843209. I'm not sure if we have an official way of enforcing that in this repo, but we can at least bump some dependencies which have been blocked on making 3.8 the minimum.