-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nimbus-fml: Make the output deterministic. #6283
Conversation
3e5d8b9
to
a7d200d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6283 +/- ##
=======================================
Coverage 22.66% 22.66%
=======================================
Files 332 332
Lines 29804 29804
=======================================
Hits 6754 6754
Misses 23050 23050 ☔ View full report in Codecov by Sentry. |
Thanks so much for doing this, @PieroV! This looks great to me—though it looks like the test fixtures might need updating, from those Clippy and test failures 👀—but let's have Charlie and Beth give the official review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye, Lina is right, there's a few things you'll need to adjust but otherwise this looks great!
For clippy, run this from the base repo directory and it'll show you its issues: ./automation/tests.py rust-clippy
cargo test
in the /components/support/nimbus-fml
folder should show you the test failures.
All-in-all I think there shouldn't be too much to change to get this in a spot where it's good to merge!
a7d200d
to
d739b1a
Compare
The pull request has been modified, dismissing previous reviews.
I tried to run Should I pass additional arguments? |
Changed some HashMaps with BTreeMaps to ensure the order of the output is deterministic.
d739b1a
to
db52b2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! Thank you for your contribution ❤️
Changed some HashMaps with BTreeMaps to ensure the order of the output is deterministic.
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.