Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Glean v60.5.0 #6339

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Update to Glean v60.5.0 #6339

merged 1 commit into from
Aug 7, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Aug 7, 2024

It seems at the moment we need to coordinate this again, as I'm running into build problems when updating it only in m-c (https://bugzilla.mozilla.org/show_bug.cgi?id=1911767)

I suspect this might be due to our removal of service-glean and thus the changed dependency tree, but I'm not sure.
Regardless, this seems like an easy thing and we can land that tomorrow with the next a-s nightly.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.63%. Comparing base (56e868a) to head (12c6d84).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6339   +/-   ##
=======================================
  Coverage   22.63%   22.63%           
=======================================
  Files         333      333           
  Lines       29835    29835           
=======================================
  Hits         6754     6754           
  Misses      23081    23081           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badboy badboy added this pull request to the merge queue Aug 7, 2024
Merged via the queue into mozilla:main with commit 236fdd9 Aug 7, 2024
17 checks passed
@badboy badboy deleted the glean-update-60.5.0 branch August 7, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants