Remove the font tests command, and related logic, from the bots #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mozilla/pdf.js#17263 is in place, we will no longer run the font tests on the bots, which means that the font tests command should be removed. Moreover, we can get rid of all submodule installations because the project won't have any submodules anymore after that patch, which simplifies the code and reduces runtime of all tests a bit (note that the submodules were also installed for tests that didn't need them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If mozilla/pdf.js#17263 is in place, we will no longer run the font tests on the bots, which means that the font tests command should be removed. Moreover, we can get rid of all submodule installations because the project won't have any submodules anymore after that patch, which simplifies the code and reduces runtime of all tests a bit (note that the submodules were also installed for tests that didn't need them).
/cc @calixteman @Snuffleupagus