Remove linting from the makeref command, and use the locally-installed version of Gulp instead a globally-installed one
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting is migrated to GitHub Actions and runs for every pushed change, so it's not necessary to repeat it during the `makeref` command. We don't do this for other bot commands either, and removing it simplifies the code and shortens the runtime.
…d one The globally-installed version of Gulp on the bots is old, and recently we moved away from using globally-installed dependencies in favor of using locally-installed ones for maintainability, isolation and reproducibility of build environments. For more information, refer to PRs mozilla/pdf.js#17913 and mozilla/pdf.js#17489. In mozilla/pdf.js#18197 we have seen that even though locally Gulp 5 is installed the global version is preferred by the bots because the `gulp` command (available in the PATH) is used instead of `npx gulp` which prefers the locally-installed version from the `node_modules` folder. This commit fixes the issue by making all Gulp invocations use `npx gulp` instead, similar to what we already did in the GitHub Actions pipelines.
timvandermeij
changed the title
makeref command, and use the locally-installed version of Gulp instead a globally-installed one
|
Thank you for reviewing! Could you deploy this change to the Linux and Windows bots? I'll retrigger the tests once that's completed. |
|
@timvandermeij, it should be done, tell me if something goes wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages contain more details about the individual changes.
Fixes a part of mozilla/pdf.js#11851.
Unblocks mozilla/pdf.js#18197.