-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from Source Code Pro web fonts in favour of system fonts #78
Comments
I'd say references to "SourceSansPro" should be changed to the existing LESS var For cleanliness you could also comment out / remove the |
one thing that we could also do (specifically here) is check the subsetting bits for these fonts - I suspect they're set to allow subsetting, which would allow us to run a proxy for serving the webfonts with only—say—the Latin blocks, drastically bringing down the resource sizes - the client would request "SourceSansPro.woff", and would receive a subset version instead of the large-coverage full version. |
…f system fonts
https://github.com/humphd/brackets/pull/110 fixes this issue |
…f system fonts
Brackets loads 300K+ of (gzipped) web fonts, and switching over to using system fonts is a pretty big saving. @peterflynn wisely suggested moving away from web fonts in adobe#10680 (comment), suggesting we use a
font-family
of"Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, fixed;
. I did a quick test of this, and with other size optimization things we're doing, it gets us down to ~600K (gzipped), which is pretty good for a complete desktop editor, filesystem, etc.I'm trying to decide the best way to make this switch, specifically how to do it with the least disruption to Brackets' code. The bulk of the Brackets font stuff is in https://github.com/adobe/brackets/blob/ae17456a596965a1247b79ddb82c6e1518bc6e5e/src/styles/brackets_fonts.less. However, looking around, there are a bunch of places that assume that either SourceSansPro or SourceCodePro have been defined, and therefore downloaded:
@Pomax and/or @peterflynn, what's the best way to do this for the browser case? It's too bad that all the uses of
font-family: SourceSansPro;
andfont-family: SourceCodePro;
in the less files weren't being done with variables,font-family: @SourceSansPro;
or the like.The text was updated successfully, but these errors were encountered: