This repository has been archived by the owner on Jan 31, 2018. It is now read-only.
Bug #3406 - use mediatypes.js to get media info if saved JSON has an inv... #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2013 14:48
| @@ -589,6 +641,13 @@ | |||
| if ( importData.duration >= 0 ) { | |||
| _duration = importData.duration; | |||
| _this.url = "#t=," + _duration; | |||
| doImportTracks(); | |||
| } else { | |||
| MediaTypes.getMetaData( importData.url[ 0 ], function success( data ) { | |||
There was a problem hiding this comment.
What is importData.url isn't an array at this point? We have code at that checks if it is or not. We might need to move this down here to happen before.
There was a problem hiding this comment.
I think Matt is right here.
I think we can do better to move this check lower down.
| var firstSource; | ||
|
|
||
| // If sources is a single array and of type null player, don't bother making a sequence. | ||
| if ( url.length > 1 || !( /#t=\d*,?\d+?/ ).test( url[ 0 ] ) ) { |
There was a problem hiding this comment.
Make this use mediaTypes.checkUrl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...alid duration
https://webmademovies.lighthouseapp.com/projects/65733/tickets/3406