Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 211: Do not error on spread operator #215

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Issue 211: Do not error on spread operator #215

merged 2 commits into from
Nov 10, 2022

Conversation

mozfreddyb
Copy link
Collaborator

No description provided.

@mozfreddyb
Copy link
Collaborator Author

This should fix #211, but leaves #214 as follow-up

@mozfreddyb mozfreddyb force-pushed the issue-211-spread-undefined-args branch from eb4820f to d731aaf Compare November 4, 2022 14:24
@mozfreddyb mozfreddyb requested a review from rpl November 7, 2022 13:21
rpl
rpl approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nit about explicitly adding to the tests also the case for the other AST that was triggering the same error (a call with just one parameter).

tests/rules/method.js Show resolved Hide resolved
@mozfreddyb mozfreddyb merged commit 3bb294c into main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpl rpl rpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mozfreddyb @rpl