Intent to Ship Email

[shell1]

This email should only be generated if they click "send email" next to the checklist item for "Intent to Ship email Sent".

All comments will be addressed and included in this the template here: https://docs.google.com/document/d/1LknFtapAZ2OQtXzufRlgwwHjDrkCrQHucXgBTzDlZ5g/edit#heading=h.54ufojhvugj6

this is what I'd like the template to say and where it should get it's info

help should link here: https://mana.mozilla.org/wiki/display/FIREFOX/Pref-Flip+and+Add-On+Experiments#Pref-FlipandAdd-OnExperiments-IntenttoShipemailsent

To: [email protected]
cc: {Creator and anyone else we know about from experiment}
From: {either Experimenter Bot (if possible) or use [email protected]}
Summary: SHIELD Study Intent to ship: {SHIELD_study_name} on Firefox {version} {channel}

Hello Release Drivers,

This request is coming from information entered in Experimenter. Please reach out to the person(s) on cc: with any questions, details, or discussion. They will email an update if any of the key information changes. Otherwise they will reach out once the study has fully passed QA for Release Management sign-off.

Experimenter Bug: {Experimenter bug number}
Experimenter URL: {link to experiment detail page}
Study owner: {experiment requester}
Description: {Short Description}
Timeline & Channel: {version} {channel}
Intended study dates: {proposed start date} - {proposed end date}
Percent of Population: {percent of population}
Platforms: {platforms}
Locales: {Locales and Geographic areas}
QA Status: {QA Status}
Meta Bug: {Feature Meta Bug}
Related links: {links to related work}
Risk: {Risk Box - only if it exists}
Technical Complexity: {Technical Complexity Box - only if it exists}

Thank you!!

[shell1]

I made a mistake at the end of this email template - and grouped Risk and Technical Complexity together. The last item that is populated should be....

Risk: {Risk Box - only if it exists}
Technical Complexity: {Technical Complexity Box - only if it exists}

[peterbe]

@shell1

I made a mistake ...

I see that you edited the issue description. Did you correct the "Risk" and "Technical Complexity" as per that second comment? Because it doesn't seem to match.
Perhaps I'm just reading you wrong. Perhaps what you mean is to simply add one more line that is "Technical Complexity: {Technical Complexity Box - only if it exists}"

[shell1]

ugh - sorry @peterbe . I didn't realize I could edit old comments and was treating it like bugzilla. Just edited the Initial comment to reflect the desired state. It is to replace single "risk and technical complexity" with 2 options. One for "risk" and one for "technical complexity".

Sorry to make you parse the initial ask and change requests - instead of updating the initial ask.

[peterbe]

Regarding...

Platforms: {platforms}

Where does this come from? I see no mention of platforms (or platform) anywhere in the code.

[peterbe]

Regarding...

Locales: {Locales and Geographic areas}

As far as I can, we don't have this. But in the Population Filtering we have a textarea which we could attempt to parse out by looking for Locales: .... But that feels very fragile.

And what is "Geographic areas"? Again, in the Population Filtering it has "Geographic regions:".

[shell1]

:( this should be blocked on landing #971. that will break those out into separate fields - from all inside "population filtering" blob.

[peterbe]

This comment about a different email address seems to NOT be in the issue (anymore?). Either way, changing the email address is a matter of asking CloudOps to change a configuration. If it's the intention to use a DIFFERENT email specifically for the Intent to Ship functionality we can certainly do that too.

…

On Thu, Mar 7, 2019 at 5:18 PM Shell Escalante ***@***.***> wrote: @peterbe <https://github.com/peterbe> we just got an update on the email address we'd all been using. Apparently that includes public folks as well - and we only want to email the more restricted ***@***.*** (instead of release-drivers@). Updating the description of this one and other related issues. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#747 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABocx1LNDQ3FNmSpHRL_kN-qetbL7GLks5vUZBDgaJpZM4ZodLh> .

-- Peter Bengtsson Mozilla Services Engineering https://www.peterbe.com

[glasserc]

Following up on this. Front-end code to make this work is a little more complicated than is suggested in #984 (comment) because we're already "in" a <form>, which is not permitted to contain other <form>s. Options I see:

• Make the button submit to the same view as the rest of the form, but do so in a way that is detectable by the view somehow. This means making ExperimentReviewUpdateForm more complicated.
• Wire up some AJAX to intercept the button and fire a request to a standalone view. This is technically easier but is a bit of a different UX than the rest of Experimenter.

One question that might help clarify: what happens if I check a bunch of checkboxes and then click Send Email? Is it preferable that we save those checked boxes, that we lose the checked boxes, or that we stay on the same page with the same state of the checked boxes?

[glasserc]

I guess "only if it exists" means if the field is a non-empty string?

How should "locales and countries" be displayed? One list, or maybe some text to distinguish between locales vs. countries?

[glasserc]

Should "proposed start date" and "proposed end date" have any specific format? How do you feel about "Jan 02, 2019 - Jan 14, 2019 (12 days)"? Or would you prefer 2019-01-02 - 2019-01-14?

[glasserc]

Should "locales" and "countries" be displayed as codes, or as human-friendly descriptions, or what? Edit: I guess I can just go with the existing formats, which are e.g. Paraguay (PY).

[mythmon]

+1 to the existing format of using both the human-friendly description and the code.

[peterbe]

Should "locales" and "countries" be displayed as codes, ...

The template for experiment details page
https://github.com/mozilla/experimenter/blob/master/app/experimenter/templates/experiments/section_population.html#L11-L27
demonstrates how it displays the countries and locales when you're looking at the experiment. It uses the Locale.__str__ and Country.__str__ as the formatter.

[glasserc]

Not all experiments have projects. What should I do if it doesn't have one?

[jaredlockhart]

@glasserc Sorry that was miscommunicated it shoudln't be project it should be:

     Experimenter URL: {link to experiment detail page}

which can be accessed by

    experiment.experiment_url