Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new dump subcommand & cleanup json output #550

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

badboy
Copy link
Member

@badboy badboy commented Jan 23, 2023

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@badboy
Copy link
Member Author

badboy commented Jan 23, 2023

I should add a test 🤔

@badboy badboy force-pushed the json-dump-and-no-internal-fields-anymore branch 3 times, most recently from 4fcddf1 to 92a1859 Compare January 24, 2023 10:41
@badboy badboy force-pushed the json-dump-and-no-internal-fields-anymore branch from 92a1859 to 33c939f Compare January 24, 2023 11:59
@badboy badboy enabled auto-merge (rebase) January 24, 2023 11:59
@badboy badboy merged commit 342cbf8 into main Jan 24, 2023
@badboy badboy deleted the json-dump-and-no-internal-fields-anymore branch January 24, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant