Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1912724 - Revert "Bug 1906941 - Update kotlin jinja template import statement (#740)" #744

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Aug 13, 2024

This reverts commit 55f5e77.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@badboy badboy requested a review from travis79 August 13, 2024 14:21
@badboy badboy requested a review from a team as a code owner August 13, 2024 14:21
@badboy badboy changed the title Revert "Bug 1906941 - Update kotlin jinja template import statement (#740)" Bug 1912724 - Revert "Bug 1906941 - Update kotlin jinja template import statement (#740)" Aug 13, 2024
@badboy
Copy link
Member Author

badboy commented Aug 13, 2024

the HistogramMetricBase alias exists here in mozilla-release: https://searchfox.org/mozilla-release/rev/4f956737532738cd1a3bc1869140587e855e5c86/mobile/android/android-components/components/service/glean/src/main/java/mozilla/components/service/glean/private/MetricAliases.kt#20
And here in current Glean: https://github.com/mozilla/glean/blob/f83e6c3606d552ea87d2b3ae5d9040b01d20f99c/glean-core/android/src/main/java/mozilla/telemetry/glean/private/HistogramBase.kt#L26-L30

So Firefox 128/129 will continue to use the service-glean alias just fine.
Firefox 130+ has service-glean removed and will thus use the HistogramMetricBase alias from Glean directly.
In a followup we bring back the use of HistogramBase and remove the alias.

@badboy badboy merged commit 1f06457 into main Aug 14, 2024
8 checks passed
@badboy badboy deleted the revert-alias-usage branch August 14, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants