Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1915744 - Rust codegen: use correctly named parameter #750

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Bug 1915744 - Rust codegen: use correctly named parameter #750

merged 1 commit into from
Aug 30, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Aug 30, 2024

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@badboy badboy requested a review from a team as a code owner August 30, 2024 12:38
@badboy badboy requested review from travis79 and removed request for a team August 30, 2024 12:38
@badboy badboy mentioned this pull request Aug 30, 2024
Merged
@badboy badboy requested a review from chutten August 30, 2024 14:09
chutten
chutten approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and this is tested in mozilla/glean#2947, I see.

@badboy badboy force-pushed the rust-sample-no-extras-event-regression branch from c16a3b9 to 0d97ca8 Compare August 30, 2024 14:15
@badboy badboy enabled auto-merge (rebase) August 30, 2024 14:16
@badboy badboy merged commit 265613d into main Aug 30, 2024
8 checks passed
@badboy badboy deleted the rust-sample-no-extras-event-regression branch August 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutten chutten chutten approved these changes

@travis79 travis79 Awaiting requested review from travis79 travis79 is a code owner automatically assigned from mozilla/glean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badboy @chutten