This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Validate bewit MAC before expiry #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking expiry before validating the MAC means that we are passing untrusted values into parseInt, which might have unintended consequences (also consider other languages that copy the algorithm here since this is the reference implementation). This is only done in the wrong order for bewit validation, regular header auth already checks the MAC first. Had to update the other expiry test since it apparently didn't have a valid MAC.
thusoy
commented
Jun 14, 2023
| @@ -377,7 +377,7 @@ exports.authenticateBewit = async function (req, credentialsFunc, options) { | |||
|
|
|||
| const bewit = { | |||
| id: bewitParts[0], | |||
| exp: parseInt(bewitParts[1], 10), | |||
There was a problem hiding this comment.
Moved this parsing until after the mac has been validated.
lotas
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking expiry before validating the MAC means that we are passing untrusted values into
parseInt, which might have unintended consequences (also consider other languages that copy the algorithm here since this is the reference implementation). This is only done in the wrong order for bewit validation, regular header auth already checks the MAC first.Had to update the other expiry test since it apparently didn't have a valid MAC.