Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to download files with a different extension for Windows builds #119

Closed
davehunt opened this issue Jul 25, 2013 · 1 comment
Closed
Milestone

Comments

@davehunt
Copy link
Member

Command to replicate:

$ mozdownload -a firefox -t daily -p win32 --branch=mozilla-central --extension=txt

This is due to the expectation of 'installer' in the file name.

Proposed fix:

diff --git a/mozdownload/scraper.py b/mozdownload/scraper.py
index 67732bd..19a739e 100755
--- a/mozdownload/scraper.py
+++ b/mozdownload/scraper.py
@@ -401,8 +401,8 @@ class DailyScraper(Scraper):
                         'linux64': r'\.%(EXT)s$',
                         'mac': r'\.%(EXT)s$',
                         'mac64': r'\.%(EXT)s$',
-                        'win32': r'(\.installer)\.%(EXT)s$',
-                        'win64': r'(\.installer)\.%(EXT)s$'}
+                        'win32': r'(\.installer)?\.%(EXT)s$',
+                        'win64': r'(\.installer)?\.%(EXT)s$'}
         regex = regex_base_name + regex_suffix[self.platform]

         return regex % {'APP': self.application,
@whimboo
Copy link
Contributor

whimboo commented Nov 18, 2013

PR #183 has been merged now. Thanks Johannes!

@whimboo whimboo closed this as completed Nov 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants